Comments on: Code reviews or testing?

By: DominikCavin

DominikCavin — Mon, 27 Mar 2017 14:59:02 +0000

I see your blog needs some fresh content. Writing manually is time consuming, but there is solution for this hard task.
Just search for – Miftolo’s tools rewriter

By: Jim

Jim — Mon, 03 May 2010 17:57:09 +0000

ugh. Static analysis, not Static testing.

By: Jim

Jim — Mon, 03 May 2010 17:56:46 +0000

Not a .NET guy, so I don’t know the static testing tools there. My development environment is typically either Eclipse with plugins or vim plus cscope/ctags/valgrind which can handle both my Java and C++ needs.

When you write a static analysis article, don’t just echo Wikipedia. Speak to what works and what doesn’t, as well as what it has changed about how you write code now that a tool has shown you the error of your ways.

By: gb

gb — Sun, 02 May 2010 17:30:54 +0000

Jim, thank you for your input.
You are right I do not mention static code analysis tools in this article.
I will prepare a static code analysis tool article to address this.
For .NET you can use stylecop http://code.msdn.microsoft.com/sourceanalysis creating an XML file with the rules you want to enforce.

By: Jim

Jim — Fri, 23 Apr 2010 00:26:35 +0000

I would add preparation from the review team is key:
* Prior to a code review, source code should be presented to the review team so that they can come in to the review prepared.
* If design artifacts are available, the review team should have access to those during their prep work

Then, add that using your tools to take out common hangups for code reviews:
* Static code analysis tools can find normal stuff. I see you’ve got them in your references, but you did not speak to them.

* An IDE can apply a standard code format to code. Don’t let the reviewers get hung up on use of whitespace, where the {}s are, etc. Let the IDE standardize that for the team.
Eclipse will let you distribute an xml of the standard formatting, then you just ctrl-shift-f to format a block or all; vim does the same with =, etc.

Speaking to code reviews with 4 people you’re thinking of the Fagan inspection. http://en.wikipedia.org/wiki/Fagan_inspection

I think both Design and Code reviews are important. Catching problems in Design makes it easier to fix them before they get to Code.

Can you eliminate Test? No, I don’t think so.
Can you eliminate some of what Test should catch by having good reviews? Yes.

By: JAY WAGNER

JAY WAGNER — Thu, 22 Apr 2010 11:31:47 +0000

I happened to see your post through digg.com.Wow, this is a very good one. very informative.I subscribed to your RSS feed by the way!Thanks, this is really cool!